Addepar / Addepar/ember-table

3.0 RFC/epic: Drop support for IE11, Ember <2.4, and more

Open
#819 5 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.0
Dominant language
JavaScript
Stars
1.7k
Forks
351
Avg merge
1d 22h
Merged PRs (30d)
1

Description

Motivation

There are several costs to ember-table supporting legacy platforms, and we're ready for a major release.

  • Contributors keep stumbling on the legacy use of sendAction in this codebase (most recently at https://github.com/Addepar/ember-table/pull/818). Today we cannot remove sendAction since it is required for Ember 1.12 and this library supports Ember 1.12.
  • Additionally this library supports IE11 despite that browser being extremely uncommon in modern usage. Indeed at Addepar we no longer have a need to support IE11, and I think we're one of the last.
  • We want to land https://github.com/Addepar/ember-table/pull/814, but may require a breaking change to the DOM (a new <div>)
  • We want to drop support for legacy Node, < v10
  • As part of an effort to update the ember-cli-sass version used here and elsewhere we make changes in https://github.com/Addepar/addepar-style-toolbox/pull/38 which may alter how the SASS of an application works (no longer would an example app have a patched @import to import only once, instead an application should provide that functionality itself if desired).

The plan & progress

The repo now has a branch 3.0-beta, in draft state at https://github.com/Addepar/ember-table/pull/831. We will land patches for an eventual 3.0 release into that branch, and will make incremental beta releases along the way. Already you can find v3.0.0-4 released via NPM.

I propose a list of changes before a 3.0 final is declared. The task list is:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the 3.0-beta branch and review the remaining unchecked items in this issue, especially vertical-collection 2.0, open 3.0 issues and pull requests, and the major release. The mentioned entry points include config/ember-try.js, package.json, and addon/-private/sticky/legacy-sticky-polyfill.js. Done means the remaining 3.0 work is resolved and a major ember-table release is cut.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system, frontend, release
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.