Row Selection might need another mode
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 351
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 1
Description
Hello!
We have the use-case where we'd like the same selection as the checkboxSelectionMode="multiple" but on the row, meaning being able to click on a first row, selecting it, clicking another having both selected.
It is meant to be on : let toggle = event.ctrlKey || event.metaKey; (ember-tr/component.js)
Maybe we could add a property like let toggle = event.ctrlKey || event.metaKey || this.get('rowToggleMode');?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ember-tr/component.js at the let toggle = event.ctrlKey || event.metaKey line. Trace how row selection and checkboxSelectionMode="multiple" are handled, then determine how a row toggle mode should expose the requested multi-row selection behavior. Done means clicking one row and then another can leave both selected without requiring the modifier key.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100