Range selection does not work on first try
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 351
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 1
Description
Hello!
When using the ranged selection (shift key pressed), on the first try, nothing is selected.
When looking at the code, the culprit is quite obvious:
if (range) {
// Use a set to avoid item duplication
let { _lastSelectedIndex } = tree;
let minIndex = Math.min(_lastSelectedIndex, rowIndex);
let maxIndex = Math.max(_lastSelectedIndex, rowIndex);
Of course, _lastSelectedIndex is undefined therefore Math.min/max is NaN.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the range-selection code containing the shown _lastSelectedIndex logic and trace how the first selected row is recorded. Verify that the first Shift-range attempt selects the expected rows rather than producing undefined bounds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100