Addepar / Addepar/ember-table

No column auto resizing when manual resizing disabled

Open
#627 0 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
351
Avg merge
1d 22h
Merged PRs (30d)
1

Description

There seems to be no v2 equivalent for the the legacy column configuration:

// Column cannot be manually resized, but automatically resizes to fill space in the table.
canAutoResize: true,
isResizable: false,

I think this is related to the isResizable option being more restrictive than its predecessor: the column cannot be resized manually or automatically. It overrides "equal-column" fill mode and "eq-container" width constraint.

For example...
let legacyColumns = [
  { headerCellName: 'A', contentPath: 'A', canAutoResize: true, isResizable: false },
  // ...B, C..
];

let columns = [
  { name: 'A', valuePath: 'A', isResizable: false },
  // ...B, C...
]
<h4>ember-table-legacy</h4>
{{ember-table-legacy
  columns=legacyColumns
  content=rows
  hasFooter=false
}}

<h4>ember-table (v2)</h4>
{{#ember-table as |t|}}
  {{ember-thead api=t 
    columns=columns
    fillMode="equal-column"
    resizeMode="fluid"
    widthConstraint="eq-container"
  }}

  {{ember-tbody api=t rows=rows}}
{{/ember-table}}

et2_etl_is_resizable_false

If you enable isResizable for v2, columns spread equally (but manually resizable)...

et2_etl_is_et2_resizable_true

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the legacy and v2 examples from the issue, focusing on the interaction between isResizable, equal-column fillMode, fluid resizeMode, and the eq-container widthConstraint. Done means columns with manual resizing disabled still automatically fill the table width while remaining non-resizable by hand.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.