Updating tree-node and linked-list-tree imports to use CollapseTree
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 351
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 1
Description
Hello, I'm working on updating to the latest beta on npm (4) from commit 600fed454. I initially encountered an error that 'ember-table/utils/tree-node' module could not be found. I come to find that utils/tree-node no longer exists, and has/is being refactored into CollapseTree along with LinkedListTree. I don't know if CollapseTree can be swapped in directly for LinkedListTree, but I tried that via import LinkedListTree from 'ember-table/-private/collapse-tree'; However, I can't find how what I would do for TreeNode i.e. utils/tree-node. I guess it is worth noting, there does seem to still be a test that refences tree-node here: https://github.com/Addepar/ember-table/blob/8519064e2b7c6d596fb42ad7708e6caf6cf9c84e/tests/helpers/tree-generator.js
I also went out on a limb and replaced all references to table-tree with ember-table, but also don't know if that's correct or not.
Any and all help very much appreciated!
I'm on ember 2.13.3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the removed ember-table/utils/tree-node and table-tree imports with ember-table/-private/collapse-tree and LinkedListTree usage described in the issue. Start with tests/helpers/tree-generator.js, then verify that the updated imports work on Ember 2.13.3 and that the referenced tree tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100