Addepar / Addepar/ember-table

recalculate column widths on column addition/subtraction

Open
#604 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
351
Avg merge
1d 22h
Merged PRs (30d)
1

Description

Hi there!

Had a quick question:

I have a basic table that depending on a parameter I send in, adds a column to the table. If I bounce back and forth between the table with and without the column, it appears that the column widths aren't always recalculated leaving me with column widths that aren't correct. I'm probably not doing a great job of conveying this, so here's a video to show you what I'm talking about: https://cl.ly/3E1H1P2t0722

For now, I'm just going to create a separate table with specific columns but wanted to see if you had any ideas.

Thanks again for all of your hard work on this addon. It's awesome!

Cheers.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the column toggling scenario shown in the linked video, comparing the table with and without the conditional column. Trace the table's column-width recalculation entry point and determine what should happen after a column is added or removed. Done means widths are recalculated correctly when switching between both table states.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.