footer row styling issue
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 351
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 1
Description
I'm running into an issue with footer rows, I narrowed it down a bit and created a twiddle for it
https://ember-twiddle.com/24a4b9210f35029a0000cb459ffdea6f
The issue is that there is a 1px space between the footer rows and the table rows can be seen in the gapas you scroll down the table. It seems to happen when you are also using the ember-bootstrap addon and have a border set on tr and set a max size on the table.
I assume it has to do with how the bottom of the td is calculated in this scenario. In the twiddle, td has a bottom of 21px, when i change it to 20px then the gap goes away
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Ember Twiddle and reproduce the footer-row gap while using ember-bootstrap, borders on tr, and a maximum table size. Inspect the footer and table row sizing around the reported td bottom value, then verify that scrolling shows no 1px gap between the footer rows and table rows.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100