Addepar / Addepar/ember-table

Failing build due to addon.sass not found

Open
#581 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
351
Avg merge
1d 22h
Merged PRs (30d)
1

Description

The problem

When attempting to use ember-table in a project, that uses sass files for styles, then the build fails.
This happens by default here, because ember-table has styles in both
addon and app directories.

image

Fix

As documented in https://github.com/aexmachina/ember-cli-sass#alternative-addon-usage
The Table does exactly that, but as mentioned there are styles inside addon directory as well, and they mustn't be there, because that's The Problem.

  • delete addon/styles
  • document that the addon consumer should import the styles to their project like this:
@import 'ember-table/default'

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the linked ember-cli-sass alternative addon usage first, then inspect the addon's addon/styles directory and the existing style locations. Done means removing addon/styles and documenting the consumer import of ember-table/default in the project's Sass styles.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, sass
Domain
build-system, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.