Addepar / Addepar/ember-table

Add touch handlers for various features

Open
#552 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
351
Avg merge
1d 22h
Merged PRs (30d)
1

Description

Certain features like row selection and sorting currently do not work on mobile because they only aupport click events. We should likely convert these to Hammer handlers that can detect events from different sources, and possibly update apis like onClick to reflect being more general (e.g. onPress)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating the row-selection and sorting click handlers, then inspect how their onClick APIs are used. Done means those features respond to touch or other supported input sources on mobile, with any API naming changes agreed and covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, mobile-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.