Addepar / Addepar/ember-table

Numeric columns are being sorted incorrectly

Open
#1,088 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
351
Avg merge
1d 22h
Merged PRs (30d)
1

Description

This screenshot is taken from your documentation. When the Total Revenue column is sorted, its sorting the values 748, 400, 3264... where I'd expect it to sort them 3264... 748, 400. We're seeing similar issues on our numeric columns locally, sorting columns like 9, 8, 45, 3, 28, 10. Is there any way where we can indicate a column is numeric?

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files or tests are named. Reproduce the reported ordering with numeric values such as 9, 8, 45, 3, 28, and 10, then trace the table's column-sorting entry point; done means numeric columns sort by numeric value, including the Total Revenue example.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.