missing `abort` typing for `onSelect`
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 351
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 1
Description
I have run across a typing issue when trying to consume the abort helper https://github.com/Addepar/ember-table/pull/918 with a multi select table. It doesn't appear that the typings have been updated: https://github.com/Addepar/ember-table/blob/master/types/components/ember-tbody/component.d.ts
I am using 5.0.6.
This is the error message I get.
Type '(selection: BlahModel | BlahModel[], { abort }: { ...; }) => void' is not assignable to type '(rows: BlahModel | BlahModel[]) => void'.
Target signature provides too few arguments. Expected 2 or more, but got 1.
Thanks!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with types/components/ember-tbody/component.d.ts and compare the declared onSelect signature with the abort helper described in the issue and pull request 918. Update the typing so the reported two-argument callback is accepted, then verify that the TypeScript error no longer occurs for multi-select usage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100