AdamBien / AdamBien/ebank

Why does the Transaction Entity depend on the Boundary's TransactionCarrier?

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
21
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Wouldn't it be cleaner if this relationship was inversed? This is leaking Boundary internals into the Entity. Maybe I'm still misunderstanding some parts of BCE and this isn't really an issue? Is there a reason for what's essentially a DTO mapping to be part of the Entity?

From Transaction.java

// Transaction lives in the entity package
public sealed interface Transaction {
    // TransactionCarrier lives in the boundary package
    static Transaction from(TransactionCarrier transaction) {
       // ...
        };
    }
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the Transaction.java excerpt and tracing the referenced TransactionCarrier in the boundary package to understand the current dependency and mapping. Compare that relationship with the repository's BCE structure; done requires a maintainer-agreed design for whether the dependency should be inverted and which files would change.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.