AdaCore / AdaCore/gnatcoll-core

Inconsistent declarations

Open
#75 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ada
Stars
55
Forks
36
PR merge metrics
No merged PRs in 30d

Description

Hi Gnatcoll developers,

As you can see e.g. in
https://github.com/AdaCore/gnatcoll-core/blob/12821a4c8a6d1a3f6b7f34a6a6d72e58b4d88e10/src/gnatcoll-boyer_moore.adb#L136-L138
some declarations are combined,
while others are kept apart.

Do you want to be consistent in this aspect?
So either

 Prefix          : Offset_Array (1 .. From_String'Length); 
 Reverse_Prefix  : Offset_Array (1 .. From_String'Length); 
 K               : Natural := 0; 
 K2              : Natural := 0; 

or

 Prefix, Reverse_Prefix  : Offset_Array (1 .. From_String'Length); 
 K, K2                   : Natural := 0; 

If so, using the rejuvenation library we can rewrite the code to the desired format.

Greetings,
Pierre

Problem detected and solvable using Rejuvenation-Ada crate
vote for Rejuvenation-Ada as The 2022 Ada Crate Of The Year

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/gnatcoll-boyer_moore.adb around lines 136-138, the example cited in the issue, and review the two proposed declaration styles. Before changing files, obtain a decision on the preferred format and the intended scope; done means the agreed declaration style is applied consistently and the project still builds and tests successfully.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.