AdaCore / AdaCore/e3-core

e3.net.http.HTTPSession base_urls should never be None

Open
#354 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue
Dominant language
Python
Stars
32
Forks
36
PR merge metrics
No merged PRs in 30d

Description

The code in HTTPSession is very complex and some methods won't work when base_urls is not set. When base_urls is not set the callers are most of the time only using the download_file function. We should create a new download_file function that does not depend on HTTPSession.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading e3.net.http.HTTPSession and tracing callers that use download_file when base_urls is unset. Confirm which methods fail without base_urls, then isolate download_file from HTTPSession. Done means those callers work without base_urls while HTTPSession no longer depends on a missing base_urls value.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.