AdaCore / AdaCore/Ada_Drivers_Library
STM32F4 - CRC implementation faulty
Open
Nobody has claimed this yet.
- Dominant language
- Ada
- Stars
- 286
- Forks
- 165
- PR merge metrics
- No merged PRs in 30d
Description
STM32.CRC defines a new type:
private
type CRC_32 is new STM32_SVD.CRC.CRC_Peripheral;
The above leads to creating new variables instead of accessing the singleton object CRC_Periph located at a specific address.
CRC calculations fail due to this - always returning the last value written to the DR
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in STM32.CRC and inspect the CRC_32 declaration alongside STM32_SVD.CRC.CRC_Peripheral and the CRC_Periph singleton. Trace accesses to the DR register and verify the implementation uses the peripheral object at its fixed address; done means CRC calculations no longer return only the last value written to DR.
Written by the indexing model from the issue text.
Assessment
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100