AccessKit / AccessKit/accesskit

Should selection-changed fire when selected nodes become visible?

Open
#667 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.5k
Forks
114
Avg merge
8h 25m
Merged PRs (30d)
28

Description

I'm working on improving Godot accessibility. A pattern I've noticed, when
arrowing through the scene tree, is that a number of tab panels/lists become
visible as tree item selection changes. These start with an initial selection, generating a selection-changed
event when the node is added to the tree. Orca then
presents the selections from the newly visible nodes in addition to tree selection. In addition to being confusing, speech from the newly appeared list/tab selections usually cuts off selections from the tree, which is what you really want.

Nodes seem to generate selection-changed when added with selections. This behavior seems to exist on all platforms.

Should a selection change be generated when a node with selection is added but
not changed? My sense is not, and I'm happy to fix it if needed, but this
pattern exists everywhere so I thought I'd check before making an attempt.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Begin by reproducing the scene-tree selection behavior in Godot with Orca, then trace when selection-changed is emitted for nodes added with an initial selection across platforms. Done requires an agreed rule for whether this event should fire and regression coverage for that behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
godot, rust
Domain
accessibility
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.