Accenture / Accenture/AmpliGraph

ConvE has no attribute tensorboard_logs_path

Open
#264 0 comments 0 reactions 1 assignee View on GitHub

@sumitpai is already working on this.

Since Jun 24, 2022.

Dominant language
Python
Stars
2.2k
Forks
257
PR merge metrics
No merged PRs in 30d

Description

When training ConvE with early stopping, the following error gets thrown:

Traceback (most recent call last):
File "ConvE(1-n)_fb15k.py", line 47, in
early_stopping_params=early_stopping_params
File "/home/ramab/anaconda3/envs/ampligraph/lib/python3.7/site-packages/ampligraph/latent_features/models/ConvE.py", line 753, in fit
raise e
File "/home/ramab/anaconda3/envs/ampligraph/lib/python3.7/site-packages/ampligraph/latent_features/models/ConvE.py", line 744, in fit
if self._perform_early_stopping_test(epoch):
File "/home/ramab/anaconda3/envs/ampligraph/lib/python3.7/site-packages/ampligraph/latent_features/models/EmbeddingModel.py", line 832, in _perform_early_stopping_test
if self.tensorboard_logs_path is not None:
AttributeError: 'ConvE' object has no attribute 'tensorboard_logs_path'

The attribute seems to be missing from ConvE, not allowing it to be trained with early stopping regardless of parameter choice.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.