Accenture / Accenture/AmpliGraph
A spelling mistake in `ampligraph/latent_features/models/EmbeddingModel.py` or documentation causes the training model different the documentation's
@sumitpai is already working on this.
Since Jun 24, 2022.
- Dominant language
- Python
- Stars
- 2.2k
- Forks
- 257
- PR merge metrics
- No merged PRs in 30d
Description
Description
The spelling mistake in ampligraph/latent_features/models/EmbeddingModel.py or documentation causes the the strategy of generating corruptions is allways default('s,o').
Actual Behavior
I want to build a TransE model, when generates corruptions only changing tail entity.
After read the documentation, I passed the parameter embedding_model_params={'corrupt_sides': 'o'} to the TransE function to build the model.
When I single step debugging, I find that the strategy of generating corruptions is allways default('s,o').
The bug is caused by EmbeddingModel.py 667 line code corruption_sides = self.embedding_model_params.get('corrupt_side', constants.DEFAULT_CORRUPT_SIDE_TRAIN) . In this line, the variable self.embedding_model_params tries to get the value of key corrupt_side, but the documentation's key is corrupt_sides.
Solution
To solve the bug, we could pass the the parameter embedding_model_params={'corrupt_side': 'o'} to the TransE function instead of the documentation's parameter.
This is a serious mistake, fortunately,it is easy to solve, so I hope you could correct it quickly.
Thank you!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.