AcademySoftwareFoundation / AcademySoftwareFoundation/openvdb

Is file.close() intended in File::writeGrids (and respectively in File::write)

Open
#79 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
3.4k
Forks
774
Avg merge
3d 9h
Merged PRs (30d)
34

Description

Hi guys I just wanted to ask if calling file.close() in File::writeGrids is intended, as the name of the function does not suggest it, and it may cause problems to someone?

Contributor guide

Open the contributing guide

Research direction

Start by inspecting File::writeGrids and File::write to understand their file-lifecycle behavior and whether callers expect them to close the file. Check related callers or tests for the intended ownership of closing. Done when the behavior is established and the issue has a documented resolution.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.