AcademySoftwareFoundation / AcademySoftwareFoundation/openvdb
Rename NanoVDB's `tools::cuda::MergeGrids` to `TopologyUnion`
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.4k
- Forks
- 777
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 34
Description
To be more in line with OpenVDB's nomenclature, we should rename MergeGrids to TopologyUnion (or perhaps UnionTopology so the verb is first if that's consistent with other NanoVDB tools functions). Raised in review by @kmuseth:
This PR looks good to me, with one exception - the naming (which is arguably not part of this specefic PR so I wont block it). I would much prefer we renamed the MergeGrids to TopoloyUnion since it's more descriptive (merging of grids is ill-defined) and more consistent with the existing terminology in OpenVDB (openvdb::Grid and openvdb::Tree define topologyUnion).
Originally posted by @kmuseth in https://github.com/AcademySoftwareFoundation/openvdb/pull/2238#pullrequestreview-4572729918
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the codebase for the tools::cuda::MergeGrids entry point and inspect its declarations, definitions, call sites, and any related tests. Choose the agreed OpenVDB-aligned name, TopologyUnion or UnionTopology, update all references consistently, and confirm the project still builds and its relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100