AcademySoftwareFoundation / AcademySoftwareFoundation/openvdb

typo in PolygonPool::trimTriangles() method

Open Beginner friendly
#2,147 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
3.4k
Forks
777
Avg merge
3d 9h
Merged PRs (30d)
34

Description

There is a small typo in the PolygonPool::trimTriangles() method name:

https://github.com/AcademySoftwareFoundation/openvdb/blob/19013e3358971501b176b3e0816b1c3cf10633f5/openvdb/openvdb/tools/VolumeToMesh.h#L146

The following line has the 'a' and the 'n' transposed:

inline bool trimTrinagles(const size_t n, bool reallocate = false);

The corrected version:

inline bool trimTriangles(const size_t n, bool reallocate = false);

This has been the case since at least v10 (packaged in Debian 13), since that is where I noticed it. Not a big deal, but I thought I'd let you guys know!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

OpenVDB's openvdb/tools/VolumeToMesh.h at line 146 contains the misspelled PolygonPool method declaration. Start by checking that location and search for references to the method name; done means the spelling is corrected consistently without introducing mismatches.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.