AcademySoftwareFoundation / AcademySoftwareFoundation/openvdb
[BUG] CheckNormGrad() will square FLT_MAX causing a FP overflow.
Open
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 3.4k
- Forks
- 777
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 34
Description
Environment
Debian Trixie
Describe the bug
Running the unit tests with FP exceptions enabled showed that CheckNormGrad() will square FLT_MAX, causing a FP overflow.
To Reproduce
Enable FP exceptions (MR with toggle for the test will follow.)
Expected behavior
No FP overflow
Additional context
I have a fix, and will be creating an MR to address this issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating CheckNormGrad() and the unit test that exercises it. Reproduce the failure with floating-point exceptions enabled, then verify that the test suite completes without an FP overflow when FLT_MAX is handled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100