AcademySoftwareFoundation / AcademySoftwareFoundation/openvdb
[BUG] Remove FindOpenEXR.cmake
- Dominant language
- C++
- Stars
- 3.4k
- Forks
- 774
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 34
Description
The provided FindOpenEXR.cmake (and all other Find*.cmake really) is overriding OpenEXRConfig.cmake, which means that some dependency of OpenEXR may be missing.
In my specific case, OpenEXR is built with Imath, which FindOpenEXR.cmake is not providing, which result in
```
[ 21%] Building CXX object library/VTKExtensions/Readers/CMakeFiles/VTKExtensionsReaders.dir/vtkF3DEXRReader.cxx.o
In file included from /usr/include/OpenEXR/ImfRgbaFile.h:21,
from /home/glow/dev/f3d/f3d/src/library/VTKExtensions/Readers/vtkF3DEXRReader.cxx:11:
/usr/include/OpenEXR/ImfFrameBuffer.h:21:10: fatal error: ImathBox.h: No such file or directory
21 | #include
| ^~~~~~~~~~~~
compilation terminated.
```
Please let each library find themselves.
Removing FindOpenEXR.cmake seems to be resolving the issue for the general case but then I have strange unrelated macOS issues, so some care is needed here.
Contributor guide
Research direction
Start by inspecting FindOpenEXR.cmake and how the project configures OpenEXR, then reproduce the missing ImathBox.h failure from the reported VTKExtensions/Readers build. Check the effect of removing the module and investigate the noted macOS issues; done means OpenEXRConfig.cmake supplies its dependencies without breaking macOS builds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100