AcademySoftwareFoundation / AcademySoftwareFoundation/openvdb
[REQUEST] Typo FIxes and possible performance improvement in VolumeToMesh.h
- Dominant language
- C++
- Stars
- 3.4k
- Forks
- 774
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 34
Description
### Is your feature request related to a problem? Please describe.
(A clear and concise description of what the problem is)
I observed a potential improvements in VolumeToMesh.h regarding runtime performance.
### Describe the solution you'd like
(A clear and concise description of what you want to happen.)
In the file VolumeToMesh.h
1. Typo fixes: at line 3182 the function eval**Extrenal**VoxelEdgesInv should be eval**External**VoxelEdgesInv
2. Loop range improvements at line 3193. The voxels.interalNeighborsX() can be changed to voxels.minX(). The reason is that this function deals with the negative side face of voxels. The loop range is supposed to a face, instead of a whole volume as suggested by current implementation.
### Describe alternatives you've considered
(A clear and concise description of any alternative solutions or features you've considered.)
The suggested solution is the simplest.
### Additional context
(Add any other context or screenshots about the feature request here.)
The current version works, but it is simply less efficient than suggested version, as the current loop ranges include suggested loop ranges.
Contributor guide
Research direction
Open VolumeToMesh.h and inspect the code around lines 3182-3193, starting with the misspelled evalExtrenalVoxelEdgesInv function and its loop range. Done means correcting the typo and narrowing the loop to voxels.minX() as requested, while confirming the existing behavior remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100