AcademySoftwareFoundation / AcademySoftwareFoundation/OpenTimelineIO
FCPX_XML Rate Issue
- Dominant language
- C++
- Stars
- 2k
- Forks
- 351
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 1
Description
This github issue is capturing info from a slack thread: https://academysoftwarefdn.slack.com/archives/CMQ9J4BQC/p1614651960098600
if you look at 370 lines of fcpx_xml adapter based on the current Master Branch, the rate is transformed into an integer as “int(float(rate) / float(total))“. If then the rate is 23.98 or 29.98, it comes out as 23.98->23 29.98->29.
Contributor guide
Research direction
Inspect the fcpx_xml adapter around the referenced line 370 and reproduce the rate conversion with 23.98 and 29.98 inputs. Determine the intended rate representation from the adapter's surrounding logic; done means these rates are no longer truncated during conversion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100