AcademySoftwareFoundation / AcademySoftwareFoundation/OpenTimelineIO

AAF read adapter should look for type Clip when it's finding a Marker's parent element from the Track

Open
#1,243 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
2k
Forks
351
Avg merge
1d 12h
Merged PRs (30d)
1

Description

In merge request https://github.com/PixarAnimationStudios/OpenTimelineIO/pull/1239, it left markers with the Track if `target_track.child_at_time(marker.marked_range.start_time)` returns something that does not have `markers` property, for example `Transition`.

This is less-than ideal. Instead, it should probably look for `Clip` and attach the marker to the clip found.

Contributor guide

Open the contributing guide

Research direction

Start in the AAF read adapter and compare the marker-parent lookup with pull request #1239, focusing on target_track.child_at_time(marker.marked_range.start_time). Reproduce a marker whose result is a Transition; done means the marker attaches to the containing Clip instead of remaining on the Track.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend-api-design
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.