AcademySoftwareFoundation / AcademySoftwareFoundation/OpenShadingLanguage

RendererServices::good() no longer used when generating textures

Open
#1,122 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.3k
Forks
414
Avg merge
3d 1h
Merged PRs (30d)
10

Description

### Problem

While doing some texture work I noticed that the RendererServices::good() function is no longer being called when generating textures. The function serves as an interface to validate texture handles retrieved from RendererServices::get_texture_handle(). This was removed as of a5d8381afbe1ad3c16cd3db7f6e1ddf5c50e0b1f and the texture handle is now just checked if it is non NULL. What are the plans for this API moving forward? If it is no longer going to be used there should probably be some indication that it is deprecated.

### Versions

* OSL branch/version: master - 1.11.0
* OS: All
* C++ compiler: N/A
* LLVM version: N/A
* OIIO version: N/A

Contributor guide

Open the contributing guide

Research direction

Start by tracing RendererServices::good() and the texture-handle generation path, then compare the current behavior with commit a5d8381afbe1ad3c16cd3db7f6e1ddf5c50e0b1f. Determine whether the API is still expected to validate handles and document the resulting behavior or deprecation status; the issue names no files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.