AcademySoftwareFoundation / AcademySoftwareFoundation/OpenPBR

Text about decoupled reflection highlight and refraction direction unclear

Open
#310 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
CSS
Stars
793
Forks
44
PR merge metrics
No merged PRs in 30d

Description

1. in v1.2, when talking about `specular_weight`, it is unclear whether transmittance is affected. Fresnel factors contain both Fresnel reflectance and Fresnel transmittance. We should mention explicitly that only reflectance is affected, not the transmittance (which is not energy conserving?) and the refraction direction; or that both reflectance and transmittance are affected, but not the refraction direction.
2. When talking about dispersion, we say "We assume that `specular_ior` (including any modulation via specular_weight as in equation)", this pontentially contradicts the claim that refraction is unaffected. We need to clarify if/how modulated specular ior affects dispersion.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the v1.2 passages about `specular_weight`, Fresnel factors, refraction direction, dispersion, and `specular_ior`, including the referenced equation. Compare the wording and equation so the specification explicitly resolves which quantities are affected; done means both ambiguities are clarified without contradicting claims elsewhere.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics, documentation
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.