AcademySoftwareFoundation / AcademySoftwareFoundation/OpenPBR

`emission_luminance` soft-max should be higher than its default

Open
#280 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
CSS
Stars
793
Forks
44
PR merge metrics
No merged PRs in 30d

Description

In https://github.com/AcademySoftwareFoundation/OpenPBR/pull/231 we added `emission_weight`. As part of that change, we made the `emission_luminance` default to 1000 nits. We didn't alter the soft-max from 1000 nits though.

This means that in the UI, the values will range over [0, 1000] with the slider at the far right end of the range. That could be a bit inconvenient perhaps, as the user will have to type in a higher value to increase the luminance past the default. I'd suggest instead we make the soft-max be e.g. 2000 nits, so the slider defaults to the middle of the range.

Contributor guide

No contributing guide indexed for this repository

Research direction

Review the emission_weight change in pull request 231 and trace how emission_luminance's default and soft-max are defined for the UI. Change the soft-max so it is higher than the 1000-nit default, such as 2000 nits, and verify that the slider starts around the middle of its range.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.