AcademySoftwareFoundation / AcademySoftwareFoundation/OpenPBR

`transmission_dispersion_scale` -> `transmission_dispersion` ?

Open
#266 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
CSS
Stars
793
Forks
44
PR merge metrics
No merged PRs in 30d

Description

This is very minor, but this name `transmission_dispersion_scale ` seems unnecessarily long.
It functions as the main slider for the dispersion effect, so why not just call it `transmission_dispersion`?

(Then `transmission_dispersion_abbe_number` gives the Abbe control. It could also be abbreviated to `transmission_dispersion_abbe`).

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the repository for both transmission_dispersion_scale and transmission_dispersion_abbe_number, then inspect the specification and reference implementation locations that define or use them. Confirm the preferred shorter names before changing every relevant occurrence; done means the naming is consistent throughout the project.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.