AcademySoftwareFoundation / AcademySoftwareFoundation/OpenPBR

Account for coat IOR in base roughening

Open
#239 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
CSS
Stars
793
Forks
44
PR merge metrics
No merged PRs in 30d

Description

As discussed on [Slack](https://academysoftwarefdn.slack.com/archives/C06365EAQMP/p1725421120304839?thread_ts=1724344444.282599&cid=C06365EAQMP), the coat roughening formula we suggest in the spec:

![image](https://github.com/user-attachments/assets/6f5113a2-1198-4d81-8201-dbaafc3c2018)

incorrectly ignores the IOR of the coat. For example if the coat IOR is 1, the coat is effectively not present so there should be no roughening effect.

Generally, I think we need to do some simulations to check the actual behavior, and come up with a good fitting formula, as the theory seems a bit hand wavy at present.. At least it should be understood that these formulas are just suggested approximations, but it's not good if they're totally wrong in certain regimes.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the coat roughening formula in the specification and the linked Slack discussion. Run simulations across coat IOR values, especially IOR 1, and compare the results with the expected absence or presence of roughening. Done means the behavior is understood and the specification contains a fitting formula with its approximation limits documented.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.