AcademySoftwareFoundation / AcademySoftwareFoundation/OpenCue
Potential failure when detecting user activity.
- Dominant language
- Python
- Stars
- 957
- Forks
- 259
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 16
Description
On this line,
https://github.com/AcademySoftwareFoundation/OpenCue/blob/22c9cd9637d64cb8de06457cce3d06b0f41c66bf/rust/crates/rqd/src/system/nimby.rs#L327
I think last_time.elapsed() could return Err if there is a problem with the clock (NTP issues, clock skew). In this case we will return always false. I think we should return TRUE in that case to make sure we are not taking over the machine.
Contributor guide
Research direction
Start at rust/crates/rqd/src/system/nimby.rs line 327 and inspect how elapsed() errors are handled. Check the surrounding rqd activity-detection behavior and verify that a clock error leaves the machine protected from takeover; done means the failure path returns TRUE as requested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100