AcademySoftwareFoundation / AcademySoftwareFoundation/OpenColorIO

Should the 2023 aswf-docker container images include minizip-ng 4.0.10?

Open
#2,314 13 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.1k
Forks
503
PR merge metrics
No merged PRs in 30d

Description

The 2023.3 aswf-docker container images have minizip-ng 3.0.10, where mz.h contains an invalid hex constant:

```
#define MZ_VERSION_BUILD (03000a)
```

which breaks code in OCIOZArchive.cpp starting with OCIO 2.3.x:

```
#if MZ_VERSION_BUILD >= 040000
```

minizip-ng 4.0.10, included in the 2024 / 2025 / 2026 images fixes that:

```
#define MZ_VERSION_BUILD (0x04000A)
```

Some CI permutations in other projects want to build OCIO 2.3.x in the 2023.3 images. Would it be an issue for OCIO if 2023 images moved to minizip-ng 4.0.10?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.