AcademySoftwareFoundation / AcademySoftwareFoundation/OpenColorIO

MathUtils.h: header functions should be replaced with definitions from half.h

Open
#2,254 1 comment 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
C++
Stars
2.1k
Forks
503
PR merge metrics
No merged PRs in 30d

Description

In MathUtils.h there are some helper functions that provide hard coded numbers for some of the half data format numeric limits:

GetHalfMax, GetHalfMin, GetHalfNormMin

These should be replaced with definitions pulled from half.h

As they also appear to not be either unused or only used by MathUtils.cpp I would propose they be first removed/migrated into that translation unit and then replaced.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.