AcademySoftwareFoundation / AcademySoftwareFoundation/OpenColorIO

ocio_deps.bat script can provide wrong instructions

Open
#1,740 2 comments 0 reactions 0 assignees View on GitHub
Build Issue good first issue help wanted
Dominant language
C++
Stars
2.1k
Forks
503
PR merge metrics
No merged PRs in 30d

Description

Hello, fairly minor issue but:
(https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/main/share/dev/windows/ocio_deps.bat#L116)
On line 116 or ocio_depts.bat script, the script instructs to use `ocio_deps --vs `, however, the script does not accept `--vs` as an argument.
I would have attempted a PR myself, however, I'm unsure what the intended use is, and it seems the `MSVS` variable is never used again, so maybe it only serves as a warning in case Visual Studio is not found?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.