AcademySoftwareFoundation / AcademySoftwareFoundation/OpenColorIO

xyY calculation will fail

Open
#1,247 0 comments 0 reactions 0 assignees View on GitHub
Bug Needs Discussion
Dominant language
C++
Stars
2.1k
Forks
503
PR merge metrics
No merged PRs in 30d

Description

In the process of trying to fix this issue over at Colour, I'm 95% sure this function and the related XYZ function will fail on negatives, which as everyone know are a part of the vast majority of colour encodings for cameras and a few RGB colourspaces.

Plausible paths forward are loosely:
1. Retain the signs as 1.0 or -1.0 for each of XYZ.
2. Perform the flip flop math on the abs(XYZ) values.
3. Return the sign accordingly for each of the x, y, or Y values, as well as Z calculations.

https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/1d36d5b70eae1180aeb50e0ec3f094f3466f6b5a/src/OpenColorIO/ops/fixedfunction/FixedFunctionOpGPU.cpp#L294

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.