AcademySoftwareFoundation / AcademySoftwareFoundation/MaterialX

Multiple type signature possible problem

Open
#1,983 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.3k
Forks
451
Avg merge
4d 11h
Merged PRs (30d)
8

Description

Related to issue #1978.

I scanned other GLSL implementations for includes that look like they would follow the same pattern as `smoothstep` in the issue above.

* `mx_dodge_color3.glsl` and `mx_dodge_color4.glsl` both include `mx_dodge_float.glsl`
* `mx_burn_color3.glsl` and `mx_burn_color4.glsl` both include `mx_burn_float.glsl`
* All the `splitlr` and `splittb` glsl source code files include `mx_aastep.glsl`

These nodes look like they might also exhibit the same issue as reported - though I have not confirmed this.

Contributor guide

Open the contributing guide

Research direction

Start by reading issue #1978, then inspect the include relationships in mx_dodge_color3.glsl, mx_dodge_color4.glsl, mx_dodge_float.glsl, mx_burn_color3.glsl, mx_burn_color4.glsl, mx_burn_float.glsl, the splitlr and splittb source files, and mx_aastep.glsl. Done means confirming whether these patterns produce the same type-signature problem as smoothstep and identifying the affected files.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.