AcademySoftwareFoundation / AcademySoftwareFoundation/MaterialX
generateshader cannot validate shaders with lighting
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.3k
- Forks
- 464
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 11
Description
The generateshader.py script does not initialize lighting.
If you have a document that requires lighting then the proper code for lighting is not inserted.
Thus it will fail validation. e.g. u_numActiveLightSources is not declared.
You can test validation with glslangValidator for GLSL for instance.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading generateshader.py and reproduce the issue with a document that requires lighting. Validate the generated shader with glslangValidator, checking whether lighting declarations such as u_numActiveLightSources are present. Done means lighting-required documents generate shaders that pass validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- computer-graphics, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100