AcademySoftwareFoundation / AcademySoftwareFoundation/MaterialX

Proposal: Add `thinfilm_weight` input to supporting BSDF nodes

Open
#1,859 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.3k
Forks
451
Avg merge
4d 11h
Merged PRs (30d)
8

Description

In shading models such as `open_pbr_surface` and `gltf_pbr`, we currently end up duplicating each thin-film supporting BSDF node, in order to correctly handle the thin-film and iridescence weights that these shading models require:

https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/libraries/bxdf/open_pbr_surface.mtlx
https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/libraries/bxdf/gltf_pbr.mtlx

Would it make sense to add a `thinfilm_weight` input to each thin-film supporting BSDF node, so that this duplication would no longer be required?

This would likely provide a significant performance improvement to these shading models, especially in filtered importance sampling contexts where environment lighting must be separately sampled and summed for each of the duplicated BSDFs.

Contributor guide

Open the contributing guide

Research direction

Start by reading libraries/bxdf/open_pbr_surface.mtlx and libraries/bxdf/gltf_pbr.mtlx, focusing on the duplicated thin-film supporting BSDF nodes and their weight handling. Compare the current graph structure and relevant MaterialX node definitions, then determine the required design and validation scope; the issue does not name tests or define final acceptance criteria.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.