AcademySoftwareFoundation / AcademySoftwareFoundation/MaterialX

Shader Generation Regression: Real world units on filenames + target unit not working

Open
#1,852 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.3k
Forks
451
Avg merge
4d 11h
Merged PRs (30d)
8

Description

## Issue

It seems that units set on filenames does not work (anymore) ? This is a sample from unit tests:
```xml

















```
I assume this worked before but I don't think they are part of render tests anymore so unknown when this may have broken.
Units on floats and vectors seem to work.

Unknown what has come of target unit setting but it also appears broken at least from testing with MaterialXlXView -- as it does nothing when setting the target unit and reloading the file. Tried this programmatically from Python API and also does not seem to work.

Contributor guide

Open the contributing guide

Research direction

Start by running the cited image unit test with the filename inputs carrying distance units, then compare shader generation for the foot, meter, mile, and centimeter cases. Also inspect the MaterialXView and Python API paths used to set and reload the target unit. Done means filename units affect generated shaders and target-unit changes are reflected after reload, with regression coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.