AcademySoftwareFoundation / AcademySoftwareFoundation/MaterialX

Graph Editor: Handle Nodegraph Implementations in Non-Library files.

Open
#1,651 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.3k
Forks
451
Avg merge
6d 6h
Merged PRs (30d)
5

Description

## Issue

- Currently nodegraph implementations which are embedded in non-ibrary files which are loaded in are
viewable and editable.
- The definition does not show up as an option for adding a new node.

## Suggestion
- Either hide or template (make read-only) these graphs.
- Add the definition to the "add" UI. This should be discussed as to what it means if the file is unloaded -- should the definition stay or not. Suggestion is to mark and clear these definitions on a new file load / file clear.

### Example:
Load in the OpenPBR combined file provided in OpenPBR slack (included here) into editor.
The nodegraph implementation (circled) loads in and is editable.

![image](https://github.com/AcademySoftwareFoundation/MaterialX/assets/49369885/e7ebb785-8d69-4ab9-b987-95145cb8da48)
[open_pbr_surface_combined - .txt]
(https://github.com/AcademySoftwareFoundation/MaterialX/files/13951690/open_pbr_surface_combined.-.txt)

Contributor guide

Open the contributing guide

Research direction

Load the attached open_pbr_surface_combined .txt in the Graph Editor and inspect the file-loading, embedded nodegraph, and add-node UI paths. Confirm the intended behavior for definitions from non-library files, including whether they are editable or read-only and what happens when the file is unloaded or cleared.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.