AcademySoftwareFoundation / AcademySoftwareFoundation/MaterialX

ESSL Shader generation COMPLETE and REDUCED options under/over expose uniforms

Open
#1,638 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.3k
Forks
451
Avg merge
6d 6h
Merged PRs (30d)
5

Description

## Issue

The ESSL shader generator does not appear to work the same as the GLSL one when determining what uniforms to promote as "public" based on the "COMPLETE" and "REDUCED" interface options for generation.

The "REDUCED" options appears to remove all nodegraph inputs, and "COMPLETE" includes all nodegraph and interior node inputs.

Not sure why this differs but it makes it so that you get way to many or no inputs exposed for purposes such as UI display.

Contributor guide

Open the contributing guide

Research direction

Start by comparing the ESSL and GLSL shader generators' handling of the COMPLETE and REDUCED interface options, then reproduce how nodegraph and interior-node inputs are exposed as public uniforms. Done means ESSL exposes the same intended uniform set as GLSL without exposing all inputs or removing them all.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.