AcademySoftwareFoundation / AcademySoftwareFoundation/MaterialX

Graph Editor: Functional graphs in loaded documents are editable

Open
#1,223 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.3k
Forks
451
Avg merge
5d 18h
Merged PRs (30d)
6

Description

If a document is loaded and it contains a definition using functional nodegraphs, these graphs show
up as being editable. This could cause problems if edited as the instances could no longer work.
If you select an instance and look at it's graph, it is also editable.

Query as to what the desired behaviour is here ?

Perhaps make these non-editable (when examining the graph via the instance and
also the graph itself) for now to keep things "safe" ?

See this [test](https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/resources/Materials/TestSuite/stdlib/shader/surface.mtlx) taken from test suite. The checker definition's nodegraph is editable.

1. Graph as loaded. Functional graph is show and is editable.
![editable_functional_graph](https://user-images.githubusercontent.com/49369885/216644295-08864d77-32af-4406-9977-5240e98876e9.png)
2. Expanding an instance, gives it's nodegraph, which is also editable.
![image](https://user-images.githubusercontent.com/49369885/216646328-5786b08e-d1ce-4b12-8871-00f803c29b7b.png)

Contributor guide

Open the contributing guide

Research direction

Reproduce the behavior in the Graph Editor using resources/Materials/TestSuite/stdlib/shader/surface.mtlx, focusing on the checker definition and an expanded instance. First determine the intended behavior for functional nodegraphs, then verify the chosen behavior for both the loaded graph and the instance graph; the issue does not name implementation files or tests.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.