AcademySoftwareFoundation / AcademySoftwareFoundation/MaterialX

Gltf attribute attenuation_distance does not have a default value

Open
#1,136 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.3k
Forks
451
Avg merge
6d 6h
Merged PRs (30d)
5

Description

As [seen here](https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/libraries/bxdf/gltf_pbr.mtlx#L27):
```xml

```
And if I read the [specs](https://github.com/KhronosGroup/glTF/blob/main/extensions/2.0/Khronos/KHR_materials_volume/README.md#attenuation) correctly, the default should be `+infinity`. Should we represent that using FLOAT_MAX?

Contributor guide

Open the contributing guide

Research direction

Start with libraries/bxdf/gltf_pbr.mtlx at the attenuation_distance input and compare its declaration with the KHR_materials_volume attenuation specification linked in the issue. Determine how the default should represent positive infinity, then verify the updated MaterialX asset and any relevant validation or rendering behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.