AcademySoftwareFoundation / AcademySoftwareFoundation/MaterialX

GLSL shader generator allows for invalid "__" substring in identifiers

Open
#1,015 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.3k
Forks
451
Avg merge
6d 6h
Merged PRs (30d)
5

Description

If a shader node has a name with "__" substring within the it's name the GLSL shader generator will generate
identifiers with that string in it. This is not allowed so shader compilation will fail.
Error is:
```
error C7528: OpenGL reserves names containing '__'
```

Contributor guide

Open the contributing guide

Research direction

Start by locating the GLSL shader generator and the code that constructs identifiers from shader node names. Reproduce the issue with a node name containing "__", then verify that generated identifiers no longer contain the reserved substring and that shader compilation succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.