ARTIST-Association / ARTIST-Association/ARTIST

`Surface` class in `artist/field/surface.py` has no apparent use?

Open
#211 0 comments 0 reactions 0 assignees View on GitHub
Urgency: Low
Dominant language
Python
Stars
12
Forks
8
PR merge metrics
No merged PRs in 30d

Description

The `Surface` class in `artist/field/surface.py` seems redundant to me.

There is only one instance of this class in the entire codebase. It is used while loading the `HeliostatField` via `from_hdf5()`. A `Surface` is instantiated from a `SurfaceConfig`, only to immediately instantiate a `NURBSSurfaces`.

Later, when the `Surface` instance is used within `HeliostatField`, it simply forwards calls to `NURBSSurfaces` methods without adding any additional functionality.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.