ARMmbed / ARMmbed/sockets

Descriptions of the get addr and port in socket.h need to be updated

Open
#46 1 comment 0 reactions 0 assignees View on GitHub
mirrored
Dominant language
C++
Stars
6
Forks
18
PR merge metrics
No merged PRs in 30d

Description

Currently there are a list of failing error conditions for the following methods:

```
virtual socket_error_t getLocalAddr(SocketAddr *addr) const;
virtual socket_error_t getRemoteAddr(SocketAddr *addr) const;
virtual socket_error_t getLocalPort(uint16_t *port) const;
virtual socket_error_t getRemotePort(uint16_t *port) const;
```

Only some of these error conditions are directly returned by the socket method implementations, all others are returned by the underlying calls to the specific api functions. As they are currently not guaranteed to honour those error conditions, this documentation should be updated.

This may not be trivial however, as ideally this higher level api would have all possible error conditions without having to refer to the api implementation documentation.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.