ARMmbed / ARMmbed/mbed-drivers

Possible fixes to FunctionPointer PR (#28)

Open
#30 5 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
39
Forks
41
PR merge metrics
No merged PRs in 30d

Description

#28 introduced a number of questionable changes:
- the `clear` method in `FunctionPointerBase` and `FunctionPointerBind`. This was introduced because it _looks_ like it might be needed in MINAR. If it turns out that it's not, `clear` needs to be removed.
- private virtual destructor in `FunctionPointerBase` (following the already present private constructor). With that in mind, It might be that `FunctionPointerBind` and `FunctionPointerX` should not inherit from `FunctionPointerBase`, but rather include it, using composition (and a proper name change). This isn't an error, just a possible improvement if it turns out to be the right idea.

Contributor guide

No contributing guide indexed for this repository

Research direction

Review PR #28 and the changes involving FunctionPointerBase, FunctionPointerBind, and FunctionPointerX. Check whether MINAR requires clear, then evaluate the proposed inheritance-versus-composition design and agree on the appropriate direction. Done means the questionable changes have a settled design and are updated or removed accordingly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
embedded-iot
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.