ARMmbed / ARMmbed/ble

Duplicated functionality in GapAdvertisingParams and GapScanningParams

Open
#166 1 comment 0 reactions 0 assignees View on GitHub
enhancement mirrored
Dominant language
C++
Stars
81
Forks
71
PR merge metrics
No merged PRs in 30d

Description

GapAdvertisingParams and GapScanningParams use `MSEC_TO_ADVERTISEMENT_DURATION_UNITS()` and `MSEC_TO_SCAN_DURATION_UNITS()` respectively to convert from milliseconds to units of 0.625. However, these two functions do exactly the same operation:

```
return (durationInMillis * 1000) / UNIT_0_625_MS;
```

Therefore, this functionality is duplicated. Perhaps it should be included in a common location such as blecommon.h or BLEProtocol? These conversions are necessary because those are the units that the BLE specification uses, they are not specific to advertising or scanning params.

**NOTE:** The same goes for `UNIT_0_625_MS` in [here](https://github.com/ARMmbed/ble/blob/develop/ble/GapAdvertisingParams.h#L80) and [here](https://github.com/ARMmbed/ble/blob/develop/ble/GapScanningParams.h#L35).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.