Target-specific change in hic_hal DAP_config.h for Hani-IoT
- Dominant language
- C
- Stars
- 2.8k
- Forks
- 1.1k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 1
Description
Hi,
I have been working on implementing DAPLink for Hani_IoT board #686. Due to hardware design of this board, software reset using [this PIN](https://github.com/ARMmbed/DAPLink/blob/master/source/hic_hal/nxp/lpc4322/DAP_config.h#L154-L157) is not possible (pin is not connected with processor reset signal).
As a workaround for this issue redefining of the reset pin was made. Pin **GPIO0[7]** was selected because it is possiblity to jumper wire it with different pin using jumper wire in case reset feature is needed.
That change was tested on the board, and it is confirmed that after redefining reset pin software reset send from host PC is possible.
```
// In file source/hic_hal/nxp/lpc4322/DAP_config.h
// nRESET Pin P2_5: GPIO5[5] note: changing to GPIO0[7]
#define PORT_nRESET 0
#define PIN_nRESET_IN_BIT 7
```
I have a questions regarding that change.
1. Is is possible to do PR and merge this changes that will allow users to compile using this option?
2. If yes, is there any example code to do this. Because Contributing Guildline is clearly stating that tinkering with common source files is not allowed, and some hooks should be defined for that.
Contributor guide
Research direction
Start with source/hic_hal/nxp/lpc4322/DAP_config.h and the Contributing Guideline to understand how target-specific configuration is expected to be expressed. Confirm how Hani-IoT selects its target and validate the GPIO0[7] reset behavior on hardware. Done means Hani-IoT can be compiled with the target-specific reset configuration without changing common behavior for other boards.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100